Resolve IdString memory leaks #5483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5417, several changes ended up leaking memory at Yosys shutdown. This wasn't caught by CI, since we only run sanitizers on main. While these changes fix it, there's a couple of questions I have:
ID(...)constructed strings really be immortal? They've been possibly incorrectly used in some pmgen FPGA backendsyosys_atexitwith the same code but without marking anything live?I observed the leaks with
SANITIZER=undefined,addressbut probably only address is necessary to reproduce it.Paging @rocallahan (I'd request a review but the reviewer selection window won't let me select non-members)